Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mix of dir and files allowed. this ref #294 #296

Merged
merged 14 commits into from
Mar 3, 2024

Conversation

JeanBilheux
Copy link
Contributor

I added the possibility to define the CT as a folder and the rest as a list of files

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 94.58%. Comparing base (bfc0433) to head (15a100d).
Report is 2 commits behind head on next.

Files Patch % Lines
src/imars3d/backend/dataio/data.py 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #296      +/-   ##
==========================================
- Coverage   94.83%   94.58%   -0.26%     
==========================================
  Files          21       21              
  Lines        1239     1255      +16     
==========================================
+ Hits         1175     1187      +12     
- Misses         64       68       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@KedoKudo KedoKudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of unrelated files added to this PR. Could you clean them up? Also, it would be great if you could add some unit test for the new signature (if you are using vscode+copilot, you can ask copilot to generate the unit test for you).

_tmp.archive.dest/work-2021-04-12_15-30-36/a.txt Outdated Show resolved Hide resolved
_tmp.archive.src Outdated Show resolved Hide resolved
environment.yml Outdated Show resolved Hide resolved
img1.npy Outdated Show resolved Hide resolved
img1.tiff Outdated Show resolved Hide resolved
log.timeit Outdated Show resolved Hide resolved
notebooks/log.timeit Outdated Show resolved Hide resolved
python/imars3d/jnbui/log.timeit Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
src/imars3d/backend/dataio/data.py Show resolved Hide resolved
@KedoKudo KedoKudo merged commit 2fb979b into next Mar 3, 2024
7 of 8 checks passed
@KedoKudo KedoKudo deleted the 294_add_load_data_signature branch March 3, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants