-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mix of dir and files allowed. this ref #294 #296
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #296 +/- ##
==========================================
- Coverage 94.83% 94.58% -0.26%
==========================================
Files 21 21
Lines 1239 1255 +16
==========================================
+ Hits 1175 1187 +12
- Misses 64 68 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of unrelated files added to this PR. Could you clean them up? Also, it would be great if you could add some unit test for the new signature (if you are using vscode+copilot, you can ask copilot to generate the unit test for you).
for more information, see https://pre-commit.ci
…neutronimaging/iMars3D into 294_add_load_data_signature
I added the possibility to define the CT as a folder and the rest as a list of files